linux-mips
[Top] [All Lists]

Re: [PATCH] clean up ret_from_{irq,exception}

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] clean up ret_from_{irq,exception}
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 12 Feb 2007 16:51:57 +0000 (GMT)
Cc: vagabon.xyz@gmail.com, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20070212.234538.25910340.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45C8A477.8070906@innova-card.com> <20070211.004020.79071872.anemo@mba.ocn.ne.jp> <cda58cb80702120044o6c434032pc2f3da68a7327097@mail.gmail.com> <20070212.234538.25910340.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 12 Feb 2007, Atsushi Nemoto wrote:

> _ret_from_irq is used by dec/int-handler.S directly, so you should not
> remove it (though decstation_defconfig disables CONFIG_PREEMPT).
> 
> But looking at dec/int-handler.S again, I can not see why it uses
> _ret_from_irq, and why it manipulates TI_REGS($28) in handle_it ...
> 
> It seems dec/int-handler.S has been broken for a while.  I'll send a
> patch to fix it.  If it was ACKed, I ACK your patch.

 It works for me with 2.6.18 -- if it needs an update due to more recent 
changes, then I have not got there yet. ;-)  I plan to rewrite this bit in 
C if feasible like other platforms did too.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>