linux-mips
[Top] [All Lists]

Re: [PATCH] clean up ret_from_{irq,exception}

To: "Atsushi Nemoto" <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] clean up ret_from_{irq,exception}
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Mon, 12 Feb 2007 16:55:50 +0100
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ZSKdRfsSIzSQzMjG5C3j6e7L1ELII5rTmFtxIkwDNh4NEongGRlLsJZlaK+C66aD9VP5PMO9nhgKGT7nbBKsMgzwxhA9fUFwcv2KGdAdZ5tw281dtWbYY0IMaB4uD9D2YcuZbebewS/4EBBwdRRZN7Np+ICzWmISEJmY6/NCM8s=
In-reply-to: <20070212.234538.25910340.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45C8A477.8070906@innova-card.com> <20070211.004020.79071872.anemo@mba.ocn.ne.jp> <cda58cb80702120044o6c434032pc2f3da68a7327097@mail.gmail.com> <20070212.234538.25910340.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On 2/12/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:

_ret_from_irq is used by dec/int-handler.S directly, so you should not
remove it (though decstation_defconfig disables CONFIG_PREEMPT).


woah, you're right. the name '_ret_from_irq' looks so private to me
that I didn't think that some other code could use it...

But looking at dec/int-handler.S again, I can not see why it uses
_ret_from_irq, and why it manipulates TI_REGS($28) in handle_it ...

It seems dec/int-handler.S has been broken for a while.  I'll send a
patch to fix it.  If it was ACKed, I ACK your patch.


ok I'm waiting...
--
              Franck

<Prev in Thread] Current Thread [Next in Thread>