| To: | Thomas Koeller <thomas.koeller@baslerweb.com> |
|---|---|
| Subject: | Re: [PATCH] eXcite nand flash driver |
| From: | Thomas Gleixner <tglx@linutronix.de> |
| Date: | Sun, 11 Feb 2007 16:44:12 +0100 |
| Cc: | linux-mtd@lists.infradead.org, linux-mips@linux-mips.org |
| In-reply-to: | <200702101122.05049.thomas.koeller@baslerweb.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200702080157.25432.thomas.koeller@baslerweb.com> <1170949737.3646.29.camel@chaos> <200702101122.05049.thomas.koeller@baslerweb.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sat, 2007-02-10 at 11:22 +0100, Thomas Koeller wrote:
> > So I expect an OOPS happens on a regular base.
> I guess it is the 'static void __iomem *tgt = NULL' part that worries
> you? Think about it, that value is never used.
True.
> However, I admit it is somewhat unclean, and therefore I am changing
> it. Updated patch follows.
Yes, it is confusing and looks horrible.
tglx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: -mm merge plans for 2.6.21, David Woodhouse |
|---|---|
| Next by Date: | Re: -mm merge plans for 2.6.21, Heiko Carstens |
| Previous by Thread: | Re: [PATCH] eXcite nand flash driver, Thomas Koeller |
| Next by Thread: | [PATCH] eXcite nand flash driver, Thomas Koeller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |