linux-mips
[Top] [All Lists]

Re: [MIPS] Check FCSR for pending interrupts before restoring from a con

To: "Atsushi Nemoto" <anemo@mba.ocn.ne.jp>
Subject: Re: [MIPS] Check FCSR for pending interrupts before restoring from a context.
From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Date: Thu, 8 Feb 2007 17:30:29 +0100
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, macro@linux-mips.org
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=hlhcRTXMF7LExNHjteVbFAG7fddNT46TB1TcqXBWACLriS9xR/fQmhtUqka4qm5uptMyBqS4B0ikL95Xj7WDJAcVULfwuE9RIW7cMzOTsEWm48ydg22D/8mleIdgnlnLyNPQqov6Uf+mF+BOyXdpXln7x8xtxpA+yYDoM7qikHI=
In-reply-to: <20070209.002323.115905985.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070208.012216.103777705.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64N.0702071725150.9744@blysk.ds.pg.gda.pl> <20070208.120219.96684712.nemoto@toshiba-tops.co.jp> <20070209.002323.115905985.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On 2/8/07, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
On Thu, 08 Feb 2007 12:02:19 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> 
wrote:
Here is a first cut.  Changes in r4k_fpu.S can be reverted, and after
Franck's patchset applied, this patch can be a bit smaller.  Please
review.


yes this's going to conflict a lot with the patchset I sent...

[snip]

+static inline int
 restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc)
 {
        unsigned int used_math;
@@ -112,7 +144,8 @@ restore_sigcontext(struct pt_regs *regs,
        if (used_math()) {

sorry for the stupid question but I don't know fpu code...Here
used_math() function is used as condition whereas used_math local is
already defined. Are we sure we want to use the function here ?

--
              Franck

<Prev in Thread] Current Thread [Next in Thread>