linux-mips
[Top] [All Lists]

Re: [PATCH] eXcite nand flash driver

To: Thomas Koeller <thomas.koeller@baslerweb.com>
Subject: Re: [PATCH] eXcite nand flash driver
From: Artem Bityutskiy <dedekind@infradead.org>
Date: Thu, 08 Feb 2007 15:55:40 +0200
Cc: linux-mips@linux-mips.org, linux-mtd@lists.infradead.org, Josh Boyer <jwboyer@linux.vnet.ibm.com>
In-reply-to: <1170942627.4884.89.camel@zod.rchland.ibm.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200702080157.25432.thomas.koeller@baslerweb.com> <1170942627.4884.89.camel@zod.rchland.ibm.com>
Reply-to: dedekind@infradead.org
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2007-02-08 at 07:50 -0600, Josh Boyer wrote:
> > +   /* free the common resources */
> > +   if (likely(this->regs)) {
> > +           iounmap(this->regs);
> > +           this->regs = NULL;
> > +   }
> 
> Same likely usage comment as above.

I agree, this function will be called one or very few times, so  this
hint is not reasonable in this case.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)


<Prev in Thread] Current Thread [Next in Thread>