linux-mips
[Top] [All Lists]

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

To: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
From: Alan <alan@lxorguk.ukuu.org.uk>
Date: Mon, 5 Feb 2007 21:59:01 +0000
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <45C77B61.1080209@pmc-sierra.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <45C77B61.1080209@pmc-sierra.com>
Sender: linux-mips-bounce@linux-mips.org
>       unsigned char           hub6;                   /* this should be in 
> the 8250 driver */
>       unsigned char           unused[3];
> +     void                            *data;                  /* generic 
> platform data pointer */
>   };

Convention is "private_data"

>
>   /*
> diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h
> index 3c8a6aa..b3550cc 100644
> --- a/include/linux/serial_reg.h
> +++ b/include/linux/serial_reg.h
> @@ -37,6 +37,7 @@ #define UART_IIR_MSI                0x00 /* Modem stat
>   #define UART_IIR_THRI               0x02 /* Transmitter holding register 
> empty */
>   #define UART_IIR_RDI                0x04 /* Receiver data interrupt */
>   #define UART_IIR_RLSI               0x06 /* Receiver line status interrupt 
> */
> +#define UART_IIR_BUSY                0x07 /* DesignWare APB Busy Detect */

Please move this down a line to break it from "official" values and call
it DESIGNWARE_UART_IIR_BUSY, so it is obviously designware specific.

Otherwise looks much less invasive and messy

<Prev in Thread] Current Thread [Next in Thread>