| To: | Manuel Lauss <mano@roarinelk.homelinux.net> |
|---|---|
| Subject: | Re: [PATCH] MMC: au1xmmc R6 response support |
| From: | Pierre Ossman <drzeus-mmc@drzeus.cx> |
| Date: | Thu, 25 Jan 2007 09:31:20 +0100 |
| Cc: | linux-mips@linux-mips.org, linux-kernel@vger.kernel.org |
| In-reply-to: | <20070125081944.GA8358@roarinelk.homelinux.net> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070123100814.GA5001@roarinelk.homelinux.net> <45B65A73.90308@drzeus.cx> <20070124055202.GA6446@roarinelk.homelinux.net> <45B72F13.4040707@drzeus.cx> <20070125072000.GA8257@roarinelk.homelinux.net> <20070125081944.GA8358@roarinelk.homelinux.net> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 1.5.0.9 (X11/20061223) |
Manuel Lauss wrote:
>
> Actually, the bug is that because of MMC_RSP_R6 not being handled in
> the switch in au1xmmc_send_command(), the controller gets told that
> no response is expected. I changed the R6 to R1 in mmc.h, thats why
> it worked in the demoboard, and it also works now on the previously
> thought-to-be-broken HW.
>
So in order to detect any similar problems in the future, I'd like a
patch that adds a "default:" to that switch statement.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MMC: au1xmmc R6 response support, Manuel Lauss |
|---|---|
| Next by Date: | Re: [PATCH] MMC: au1xmmc R6 response support, Pierre Ossman |
| Previous by Thread: | Re: [PATCH] MMC: au1xmmc R6 response support, Manuel Lauss |
| Next by Thread: | Re: [PATCH] MMC: au1xmmc R6 response support, Pierre Ossman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |