linux-mips
[Top] [All Lists]

Re: [PATCH] MMC: au1xmmc R6 response support

To: Pierre Ossman <drzeus-mmc@drzeus.cx>
Subject: Re: [PATCH] MMC: au1xmmc R6 response support
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Wed, 24 Jan 2007 06:52:02 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <45B65A73.90308@drzeus.cx>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20070123100814.GA5001@roarinelk.homelinux.net> <45B65A73.90308@drzeus.cx>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11
On Tue, Jan 23, 2007 at 07:56:51PM +0100, Pierre Ossman wrote:
> > here's a trivial patch which adds R6 reponse support to the au1xmmc
> > driver. Fixes SD card detection / operation.
> > 
> NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same value so this will break
> the switch.

not in my version of 2.6.20-rc5 (and 2.6.19):

#define MMC_RSP_R1      (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE)
#define MMC_RSP_R6      (MMC_RSP_PRESENT|MMC_RSP_CRC)

Without the patch, SD card detection stops with CMD7 returning error.

Thanks,

-- 
 mll.

<Prev in Thread] Current Thread [Next in Thread>