| To: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
|---|---|
| Subject: | Re: [PATCH][RFC] Move some kernel globals from asm file to C file. |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 23 Jan 2007 16:12:26 +0000 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <20070124.003859.126141727.anemo@mba.ocn.ne.jp> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070124.003859.126141727.anemo@mba.ocn.ne.jp> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.2i |
On Wed, Jan 24, 2007 at 12:38:59AM +0900, Atsushi Nemoto wrote: > 801ce000 B fw_arg3 > 801ce004 B fw_arg1 > 801cf000 B swapper_pg_dir > 801d0000 B invalid_pte_table > 801d1000 B fw_arg2 > 801d1008 B kernelsp > 801d1010 B fw_arg0 > 801d1018 B pgd_current > 801d1020 A __bss_stop > 801d1020 A _end > > It looks less efficient while fw_arg[0-3] are all 4 byte. > > Is there any point on declaring those symbols in asm file? If > nothing, how about moving them to C file? And I can not see why > kernel_sp and pgd_current have 8-byte size even on 32-bit kernel. > > Here is a proposal patch. Comments? Looks ok but I think all the pagetable stuff should move to somewhere like arch/mips/mm/init.c. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH][RFC] Move some kernel globals from asm file to C file., Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH][RFC] Move some kernel globals from asm file to C file., Atsushi Nemoto |
| Previous by Thread: | [PATCH][RFC] Move some kernel globals from asm file to C file., Atsushi Nemoto |
| Next by Thread: | Re: [PATCH][RFC] Move some kernel globals from asm file to C file., Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |