| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable |
| From: | "Robert P. J. Day" <rpjday@mindspring.com> |
| Date: | Thu, 18 Jan 2007 11:14:12 -0500 (EST) |
| Cc: | Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, akpm@osdl.org |
| In-reply-to: | <20070118160338.GA6343@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070119.002346.74752797.anemo@mba.ocn.ne.jp> <20070118160338.GA6343@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Thu, 18 Jan 2007, Ralf Baechle wrote: > On Fri, Jan 19, 2007 at 12:23:46AM +0900, Atsushi Nemoto wrote: > > > CARDBUS_MEM_SIZE was increased to 64MB on 2.6.20-rc2, but larger size > > might result in allocation failure for the reserving itself on some > > platforms (for example typical 32bit MIPS). Make it (and > > CARDBUS_IO_SIZE too) customizable for such platforms. > > Patch looks technically ok to me, so feel free to add my Acked-by: > line. > > The grief I have with this sort of patch is that this kind of > detailed technical knowledge should not be required by a mortal > configuring the Linux kernel. that's why help info for options like that should always have a "If you're unsure about what to say here ..." paragraph. i'm big on stuff like that. :-) rday |
| Previous by Date: | Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable, Andrew Morton |
| Previous by Thread: | Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable, Ralf Baechle |
| Next by Thread: | Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable, Andrew Morton |
| Indexes: | [Date] [Thread] [Top] [All Lists] |