linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for Cobalt Server front LED

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Add support for Cobalt Server front LED
From: Florian Fainelli <florian.fainelli@int-evry.fr>
Date: Wed, 17 Jan 2007 19:04:23 +0100
Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>, linux-mips@linux-mips.org
In-reply-to: <20070117164610.GA1200@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200701151936.57738.florian.fainelli@int-evry.fr> <200701160056.00748.florian.fainelli@int-evry.fr> <20070117164610.GA1200@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.5
Hi Ralf,

This should take into account everything that has been said before.

Thanks.

Signed-off-by: Florian Fainelli <florian.fainelli@int-evry.fr>

diff -urN linux-2.6.19.1/drivers/leds/Kconfig 
linux-2.6.19.1.led/drivers/leds/Kconfig
--- linux-2.6.19.1/drivers/leds/Kconfig 2006-12-11 20:32:53.000000000 +0100
+++ linux-2.6.19.1.led/drivers/leds/Kconfig     2007-01-15 19:22:00.000000000 
+0100
@@ -76,6 +76,12 @@
          This option enables support for the Soekris net4801 and net4826 
error
          LED.

+config LEDS_COBALT
+       tristate "LED Support for Cobalt Server front LED"
+       depends on LEDS_CLASS && MIPS_COBALT
+       help
+         This option enables support for the front LED on Cobalt Server
+
 comment "LED Triggers"

 config LEDS_TRIGGERS
diff -urN linux-2.6.19.1/drivers/leds/leds-cobalt.c 
linux-2.6.19.1.led/drivers/leds/leds-cobalt.c
--- linux-2.6.19.1/drivers/leds/leds-cobalt.c   1970-01-01 01:00:00.000000000 
+0100
+++ linux-2.6.19.1.led/drivers/leds/leds-cobalt.c       2007-01-15 
19:28:09.000000000 +0100
@@ -0,0 +1,55 @@
+#include <linux/module.h>
+#include <linux/types.h>
+#include <linux/kernel.h>
+#include <linux/device.h>
+#include <linux/leds.h>
+#include <asm/mach-cobalt/cobalt.h>
+
+/* Copyright 2006 - Florian Fainelli <florian@openwrt.org>
+ *
+ * This driver let you control the Cobalt Qube/RaQ front LED
+ *
+ * 255 (max brightness) -> turn the led on
+ * 0 -> turn the led off
+ *
+ * If you want the LED to be blinking on IDE activity, select the IDE trigger
+ */
+
+static void cobalt_led_set(struct led_classdev *led_cdev, enum led_brightness 
brightness)
+{
+       switch (brightness) {
+       case LED_OFF:
+               *(volatile uint8_t *) COBALT_LED_BASE = 0;
+               break;
+       case LED_FULL:
+               *(volatile uint8_t *) COBALT_LED_BASE = COBALT_LED_BAR_LEFT | 
COBALT_LED_BAR_RIGHT;
+               break;
+       default:
+               return;
+       }
+}
+
+static struct led_classdev cobalt_led = {
+       .name = "cobalt-front-led",
+       .brightness_set = cobalt_led_set,
+#ifdef CONFIG_LEDS_TRIGGER_IDE_DISK
+       .default_trigger = "ide-disk",
+#endif
+};
+
+static int __init cobalt_led_init(void)
+{
+       return led_classdev_register(NULL, &cobalt_led);
+}
+
+static void __exit cobalt_led_exit(void)
+{
+       led_classdev_unregister(&cobalt_led);
+}
+
+module_init(cobalt_led_init);
+module_exit(cobalt_led_exit);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Front LED support for Cobalt Server");
+MODULE_AUTHOR("Florian Fainelli <florian@openwrt.org>");
diff -urN linux-2.6.19.1/drivers/leds/Makefile 
linux-2.6.19.1.led/drivers/leds/Makefile
--- linux-2.6.19.1/drivers/leds/Makefile        2006-12-11 20:32:53.000000000 
+0100
+++ linux-2.6.19.1.led/drivers/leds/Makefile    2007-01-15 19:22:18.000000000 
+0100
@@ -13,6 +13,7 @@
 obj-$(CONFIG_LEDS_S3C24XX)             += leds-s3c24xx.o
 obj-$(CONFIG_LEDS_AMS_DELTA)           += leds-ams-delta.o
 obj-$(CONFIG_LEDS_NET48XX)             += leds-net48xx.o
+obj-$(CONFIG_LEDS_COBALT)              += leds-cobalt.o

 # LED Triggers
 obj-$(CONFIG_LEDS_TRIGGER_TIMER)       += ledtrig-timer.o


Le mercredi 17 janvier 2007 17:46, Ralf Baechle a écrit :
> On Tue, Jan 16, 2007 at 12:56:00AM +0100, Florian Fainelli wrote:
> > Answering back to myself, since I fixed the stuff using the
> > COBALT_LED_PORT, here the corrected patch. Can you queue this patch for a
> > commit if it sounds acceptable to you ?
> >
> > Thank you very much in advance.
>
> Signed-off???
>
> > +void cobalt_led_set(struct led_classdev *led_cdev, enum led_brightness
> > brightness)
>
> This function is only used locally so should be static.
>
>   Ralf

Attachment: pgpFIeTlN91LE.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>