linux-mips
[Top] [All Lists]

Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag

To: "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 18/59] sysctl: ipmi remove unnecessary insert_at_head flag
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 17 Jan 2007 14:14:54 +1100
Cc: "<Andrew Morton" <akpm@osdl.org>, linux-mips@linux-mips.org, linux-parport@lists.infradead.org, heiko.carstens@de.ibm.com, ak@suse.de, linuxppc-dev@ozlabs.org, paulus@samba.org, aharkes@cs.cmu.edu, schwidefsky@de.ibm.com, tim@cyberelk.net, rtc-linux@googlegroups.com, linux-scsi@vger.kernel.org, kurt.hackel@oracle.com, coda@cs.cmu.edu, vojtech@suse.cz, linuxsh-shmedia-dev@lists.sourceforge.net, James.Bottomley@SteelEye.com, clemens@ladisch.de, xfs@oss.sgi.com, xfs-masters@oss.sgi.com, andrea@suse.de, openipmi-developer@lists.sourceforge.net, linux-390@vm.marist.edu, codalist@TELEMANN.coda.cs.cmu.edu, a.zummo@towertech.it, tony.luck@intel.com, linux-ntfs-dev@lists.sourceforge.net, netdev@vger.kernel.org, aia21@cantab.net, linux-kernel@vger.kernel.org, ralf@linux-mips.org, lethal@linux-sh.org, containers@lists.osdl.org, linux390@de.ibm.com, philb@gnu.org
In-reply-to: <1168965635875-git-send-email-ebiederm@xmission.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <m1ac0jc4no.fsf@ebiederm.dsl.xmission.com> <1168965635875-git-send-email-ebiederm@xmission.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2007-01-16 at 09:39 -0700, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@xmission.com> - unquoted
> 
> With unique sysctl binary numbers setting insert_at_head is pointless.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/char/ipmi/ipmi_poweroff.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c 
> b/drivers/char/ipmi/ipmi_poweroff.c
> index 9d23136..b3ae65e 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -686,7 +686,7 @@ static int ipmi_poweroff_init (void)
>               printk(KERN_INFO PFX "Power cycle is enabled.\n");
>  
>  #ifdef CONFIG_PROC_FS
> -     ipmi_table_header = register_sysctl_table(ipmi_root_table, 1);
> +     ipmi_table_header = register_sysctl_table(ipmi_root_table, 0);
>       if (!ipmi_table_header) {
>               printk(KERN_ERR PFX "Unable to register powercycle sysctl\n");
>               rv = -ENOMEM;


<Prev in Thread] Current Thread [Next in Thread>