linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for Cobalt Server front LED

To: Peter Horton <phorton@bitbox.co.uk>
Subject: Re: [PATCH] Add support for Cobalt Server front LED
From: Florian Fainelli <florian.fainelli@int-evry.fr>
Date: Tue, 16 Jan 2007 11:14:55 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <45ACA08F.8000203@bitbox.co.uk>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200701151936.57738.florian.fainelli@int-evry.fr> <45ACA08F.8000203@bitbox.co.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.5
Hi Peter,

The patch I resend last night is using COBALT_LED_PORT. Is there anything else 
that needs to be changed ? Thank you in advance for your answer

Le mardi 16 janvier 2007 10:53, Peter Horton a écrit :
> Florian Fainelli wrote:
> > This patch adds support for controlling the front LED on Cobalt Server.
> > It has been tested on Qube 2 with either no default trigger, or the
> > IDE-activity trigger. Both work fine. Please comment and test !
>
> Why did you add COBALT_LED_BASE when there was already a COBALT_LED_PORT
> define on the line above ?
>
> All your
>
>       *(volatile uint8_t *) COBALT_LED_BASE = n;
>
> can be replaced by
>
>       COBALT_LED_PORT = n;
>
> P.

-- 
Cordialement, Florian Fainelli
---------------------------------------------
5, rue Charles Fourier
Chambre 1202
91011 Evry
http://www.alphacore.net
(+33) 01 60 76 64 21
(+33) 06 09 02 64 95
---------------------------------------------
Association MiNET
http://www.minet.net
---------------------------------------------
Institut National des Télécommunication
http://www.int-evry.fr/telecomint
---------------------------------------------

Attachment: pgpRGQL4adCuu.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>