linux-mips
[Top] [All Lists]

Re: [PATCH] Add support for Cobalt Server front LED

To: Florian Fainelli <florian.fainelli@int-evry.fr>
Subject: Re: [PATCH] Add support for Cobalt Server front LED
From: Peter Horton <phorton@bitbox.co.uk>
Date: Tue, 16 Jan 2007 09:53:19 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <200701151936.57738.florian.fainelli@int-evry.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200701151936.57738.florian.fainelli@int-evry.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.9 (Windows/20061207)
Florian Fainelli wrote:

This patch adds support for controlling the front LED on Cobalt Server. It has been tested on Qube 2 with either no default trigger, or the IDE-activity trigger. Both work fine. Please comment and test !


Why did you add COBALT_LED_BASE when there was already a COBALT_LED_PORT define on the line above ?

All your

        *(volatile uint8_t *) COBALT_LED_BASE = n;

can be replaced by

        COBALT_LED_PORT = n;

P.

<Prev in Thread] Current Thread [Next in Thread>