linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] Fixed PCI resource fixup

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH] [MIPS] Fixed PCI resource fixup
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 11 Jan 2007 14:31:16 +0000
Cc: linux-mips <linux-mips@linux-mips.org>
In-reply-to: <200701110555.l0B5twHe006668@mbox33.po.2iij.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200701110555.l0B5twHe006668@mbox33.po.2iij.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Thu, Jan 11, 2007 at 02:55:58PM +0900, Yoichi Yuasa wrote:

> This patch has fixed IDE resources problem about Cobalt.
> 
> pcibios_fixup_device_resources() changes non-movable resources.
> It cannot be changed if there is IORESOURCE_PCI_FIXED in the resource flags. 

<Ralf> anemo: Have you seen Yoichi's patch?
<anemo> Ralf: yes, but I could not see why ...  My impression is 
IORESOURCE_PCI_FIXED and io_offset adjustment is irrerevant.
<Ralf> This whole fixup thing is really meant to handle machines where there is 
an offset between PCI bus addresses and CPU physical addresses.
<Ralf> And that exists regardless of IORESOURCE_PCI_FIXED
<anemo> I thought so too.  So I can not see why youichi's patch fix something.
<Ralf> This may be the explanation:
<Ralf> static struct pci_controller cobalt_pci_controller = {
<Ralf>         .pci_ops        = &gt64111_pci_ops,
<Ralf>         .mem_resource   = &cobalt_mem_resource,
<Ralf>         .mem_offset     = 0,
<Ralf>         .io_resource    = &cobalt_io_resource,
<Ralf>         .io_offset      = 0 - GT_DEF_PCI0_IO_BASE,
<Ralf> };
<Ralf> I think he should have io_offset = 0.

Which is what other GT-64120 platforms are using, so I wonder why that is
different on Cobalt.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>