| To: | Davy Chan <chandave-linux-mips@wiasia.com> |
|---|---|
| Subject: | Re: [PATCH] pnx8550: Fix broken write_config_byte() function in arch/mips/pci/ops-pnx8550.c |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Mon, 8 Jan 2007 15:26:27 +0000 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <20070105135646.D14007@wiasia.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20070105135646.D14007@wiasia.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.2i |
On Fri, Jan 05, 2007 at 01:56:46PM +0800, Davy Chan wrote: > There's a serious typo in the function: > arch/mips/pci/ops-pnx8550.c:write_config_byte() > > The parameter passed to the function config_access() is PCI_CMD_CONFIG_READ > instead of PCI_CMD_CONFIG_WRITE. This renders any attempts to write > a single byte to the PCI configuration registers useless. > > This problem does not exist for write_config_word() nor write_config_dword(). > > This problem has been there since kernel v2.6.17 and is still there > as of kernel v2.6.19.1. The bug exists even in 2.6.16 which is the oldest -stable branch I'm still maintaining on linux-mips.org. Patch applied. Standard rant, please add a Signed-off-by: line. See Documentation/SubmittingPatches for what this is about. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Define MIPS_CPU_IRQ_BASE in generic header, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] prom_free_prom_memory cleanup, Ralf Baechle |
| Previous by Thread: | [PATCH] pnx8550: Fix broken write_config_byte() function in arch/mips/pci/ops-pnx8550.c, Davy Chan |
| Next by Thread: | Re: [PATCH 1/3] Fix csum_partial_copy_from_user (take 2), Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |