| To: | ralf@linux-mips.org |
|---|---|
| Subject: | [PATCH] pnx8550: Fix broken write_config_byte() function in arch/mips/pci/ops-pnx8550.c |
| From: | Davy Chan <chandave-linux-mips@wiasia.com> |
| Date: | Fri, 5 Jan 2007 13:56:46 +0800 |
| Cc: | linux-mips@linux-mips.org |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.2.5.1i |
(Looks like not many people write single bytes to the PCI configuration registers on a PNX8550-based system.) There's a serious typo in the function: arch/mips/pci/ops-pnx8550.c:write_config_byte() The parameter passed to the function config_access() is PCI_CMD_CONFIG_READ instead of PCI_CMD_CONFIG_WRITE. This renders any attempts to write a single byte to the PCI configuration registers useless. This problem does not exist for write_config_word() nor write_config_dword(). This problem has been there since kernel v2.6.17 and is still there as of kernel v2.6.19.1. Patch attached. See ya... d.c.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] Sync up sibyte headers with master versions, mason |
|---|---|
| Next by Date: | Re: [PATCH 1/3] Fix csum_partial_copy_from_user (take 2), Atsushi Nemoto |
| Previous by Thread: | [PATCH] Sync up sibyte headers with master versions, mason |
| Next by Thread: | Re: [PATCH] pnx8550: Fix broken write_config_byte() function in arch/mips/pci/ops-pnx8550.c, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |