linux-mips
[Top] [All Lists]

Re: N32 shmat problem identified! Kernel fix needed.

To: Kaz Kylheku <kaz@zeugmasystems.com>
Subject: Re: N32 shmat problem identified! Kernel fix needed.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sat, 2 Dec 2006 02:24:04 +0000
Cc: linux-mips@linux-mips.org
In-reply-to: <66910A579C9312469A7DF9ADB54A8B7D4B5F5F@exchange.ZeugmaSystems.local>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <66910A579C9312469A7DF9ADB54A8B7D4B5F5F@exchange.ZeugmaSystems.local>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Fri, Dec 01, 2006 at 04:33:16PM -0800, Kaz Kylheku wrote:

> The function named sys32_shmat has no reason to exist, and is broken. It
> assumes that user space has passed a pointer to the location where the
> resulting pointer should be stored. But that is not the shmat API, and
> glibc will pass no such parameter. So a null dereference results,
> leading to EFAULT.
> 
> The fix is to remove this function from the code base and quite simply
> to wire the normal sys_shmat into the n32 syscall table. Since there is
> in fact no pointer-to-pointer argument, this function doesn't have a 32
> bit compatibility issues.

That's fixed since two months.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>