linux-mips
[Top] [All Lists]

Re: [PATCH 2.6.18] dz: Fixes to make it work

To: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH 2.6.18] dz: Fixes to make it work
From: Thiemo Seufer <ths@networkno.de>
Date: Fri, 24 Nov 2006 15:12:05 +0000
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.64N.0611241420500.20948@blysk.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64N.0611241420500.20948@blysk.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
Maciej W. Rozycki wrote:
>  This a set of fixes mostly to make the driver actually work:
> 
> 1. Actually select the line for setting parameters and receiver 
>    disable/enable.
> 2. Select the line for receive and transmit interrupt handling correctly.
> 3. Report the transmitter empty state correctly.
> 4. Set the I/O type of ports correctly.
> 5. Perform polled transmission correctly.
> 6. Don't fix the console line at ttyS3.
> 7. Magic SysRq support.
> 8. Various small bits here and there.
> 
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
>  Tested with a DECstation 2100 (thanks Flo for making this possible).
> 
>  Please apply.
> 
>   Maciej
> 
> patch-2.6.18-dz-13
> diff -up --recursive --new-file linux-2.6.18.macro/drivers/char/decserial.c 
> linux-2.6.18/drivers/char/decserial.c
> --- linux-2.6.18.macro/drivers/char/decserial.c       2006-09-20 
> 03:42:06.000000000 +0000
> +++ linux-2.6.18/drivers/char/decserial.c     2006-11-23 18:29:38.000000000 
> +0000
> @@ -23,20 +23,12 @@
>  extern int zs_init(void);
>  #endif
>  
> -#ifdef CONFIG_DZ
> -extern int dz_init(void);
> -#endif
> -
>  #ifdef CONFIG_SERIAL_CONSOLE
>  
>  #ifdef CONFIG_ZS
>  extern void zs_serial_console_init(void);
>  #endif
>  
> -#ifdef CONFIG_DZ
> -extern void dz_serial_console_init(void);
> -#endif
> -
>  #endif
>  
>  /* rs_init - starts up the serial interface -
> @@ -46,23 +38,11 @@ extern void dz_serial_console_init(void)
>  
>  int __init rs_init(void)
>  {
> -
> -#if defined(CONFIG_ZS) && defined(CONFIG_DZ)
> +#ifdef ONFIG_ZS
          ^
Minor typo. :-)

<Prev in Thread] Current Thread [Next in Thread>