linux-mips
[Top] [All Lists]

Re: [PATCH] use generic_handle_irq, handle_level_irq, handle_percpu_irq

To: sshtylyov@ru.mvista.com
Subject: Re: [PATCH] use generic_handle_irq, handle_level_irq, handle_percpu_irq
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Wed, 22 Nov 2006 22:19:57 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <45631BD2.4090509@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20061114.011318.99611303.anemo@mba.ocn.ne.jp> <45631BD2.4090509@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 21 Nov 2006 18:31:30 +0300, Sergei Shtylyov <sshtylyov@ru.mvista.com> 
wrote:
> > diff --git a/arch/mips/kernel/irq-msc01.c b/arch/mips/kernel/irq-msc01.c
> > index e1880b2..bcaad66 100644
> > --- a/arch/mips/kernel/irq-msc01.c
> > +++ b/arch/mips/kernel/irq-msc01.c
> > @@ -117,6 +117,7 @@ struct irq_chip msc_levelirq_type = {
> >     .mask = mask_msc_irq,
> >     .mask_ack = level_mask_and_ack_msc_irq,
> >     .unmask = unmask_msc_irq,
> > +   .eoi = unmask_msc_irq,
> >     .end = end_msc_irq,
> >  };
> 
>     You don't have to define eoi() method for the level flow. And you don't 
> need end() method anymore.

Yes, .eoi is not used level flow handler, but I thought this irq chip
is possibly used with handle_percpu_irq flow handler.  And I kept .end
method for old __do_IRQ users.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>