linux-mips
[Top] [All Lists]

Re: [PATCH] use generic_handle_irq, handle_level_irq, handle_percpu_irq

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] use generic_handle_irq, handle_level_irq, handle_percpu_irq
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 22 Nov 2006 12:05:52 +0000
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
In-reply-to: <45631BD2.4090509@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20061114.011318.99611303.anemo@mba.ocn.ne.jp> <45631BD2.4090509@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Tue, Nov 21, 2006 at 06:31:30PM +0300, Sergei Shtylyov wrote:

> >@@ -104,6 +105,7 @@ static struct irq_chip mips_mt_cpu_irq_c
> >     .mask           = mask_mips_mt_irq,
> >     .mask_ack       = mips_mt_cpu_irq_ack,
> >     .unmask         = unmask_mips_mt_irq,
> >+    .eoi            = unmask_mips_mt_irq,
> >     .end            = mips_mt_cpu_irq_end,
> > };
> > 
> >@@ -124,7 +126,8 @@ void __init mips_cpu_irq_init(int irq_ba
> >                     set_irq_chip(i, &mips_mt_cpu_irq_controller);
> > 
> >     for (i = irq_base + 2; i < irq_base + 8; i++)
> >-            set_irq_chip(i, &mips_cpu_irq_controller);
> >+            set_irq_chip_and_handler(i, &mips_cpu_irq_controller,
> >+                                     handle_level_irq);
> 
>    BTW, isn't IRQ7 per-CPU?

Yes and no.  On many CPUs IRQ 7 can be configured at reset time as either
the count / compare interrupt or a CPU interrupt just like the others.
It always used to be a normal CPU interrupt for R2000 class CPUs.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>