linux-mips
[Top] [All Lists]

Re: [PATCH] mips hpt cleanup: make clocksource_mips public

To: sshtylyov@ru.mvista.com
Subject: Re: [PATCH] mips hpt cleanup: make clocksource_mips public
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 13 Nov 2006 22:38:00 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <455774BD.6010706@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20061112.001028.41198601.anemo@mba.ocn.ne.jp> <455774BD.6010706@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 12 Nov 2006 22:23:41 +0300, Sergei Shtylyov <sshtylyov@ru.mvista.com> 
wrote:
>     Good to see it. :-)
>     I have a suggestion though...

Thank you for review.

> > -           mips_hpt_read = dec_ioasic_hpt_read;
> > +           clocksource_mips.read = dec_ioasic_hpt_read;
> 
>     I'd like to see clocksource_mips.name overriden there as well.

Yes now it is possible without touching generic code.  You can do it
if you wanted.  I do not have strong feeling for custom name :)

Main purpose of this patch is to remove mips_hpt_read (which saves a
few cycles).

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>