On Thu, 2 Nov 2006 11:39:12 +0000 (GMT), "Maciej W. Rozycki"
> You have removed a couple of spinlocks protecting accesses to some
> resources on the DECstation. This makes me suspicious -- after all I put
> all of them there for a reason, e.g. to make sure shadow variables are
> consistent with write-only registers. But perhaps you had a valid reason
> to believe with your changes in place they are no needed anymore. I'll
> have a closer look as soon as possible and will let you know if the
> changes are fine. Thanks for your work.
> But for now it's a NAK for the DECstation part.
Thanks you your review.
Yes, I removed ioasic_lock and kn02_lock. These were used in:
IIUC All of these are called interrupt disabled. These callers are in
lowlevel interrupt context, or having irq_desc lock with
spin_lock_irqsave, or in early stage of bootstrap. And DECstation is
not SMP system, so no further protection would be needed.