linux-mips
[Top] [All Lists]

Re: [PATCH] mips irq cleanups

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] mips irq cleanups
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 2 Nov 2006 11:39:12 +0000 (GMT)
Cc: linux-mips@linux-mips.org
In-reply-to: <20061102.020836.25912635.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20061102.020836.25912635.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2 Nov 2006, Atsushi Nemoto wrote:

> Though whole this patch is quite large, changes in each irq_chip are
> not quite simple.  Please review and test on your platform.  Thanks.

 You have removed a couple of spinlocks protecting accesses to some 
resources on the DECstation.  This makes me suspicious -- after all I put 
all of them there for a reason, e.g. to make sure shadow variables are 
consistent with write-only registers.  But perhaps you had a valid reason 
to believe with your changes in place they are no needed anymore.  I'll 
have a closer look as soon as possible and will let you know if the 
changes are fine.  Thanks for your work.

 But for now it's a NAK for the DECstation part.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>