linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS] fix wrong prom_getcmdline() definition

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH][MIPS] fix wrong prom_getcmdline() definition
From: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Date: Wed, 1 Nov 2006 07:42:25 +0900
Cc: yoichi_yuasa@tripeaks.co.jp, linux-mips@linux-mips.org
In-reply-to: <20061031134516.GA7795@linux-mips.org>
Organization: TriPeaks Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200610310445.k9V4jFXT012552@mbox33.po.2iij.net> <20061031134516.GA7795@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 31 Oct 2006 13:45:16 +0000
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Tue, Oct 31, 2006 at 01:40:07PM +0900, Yoichi Yuasa wrote:
> 
> > This patch has fixed wrong prom_getcmdline() definition.
> 
> Fortunately an __init declaration of a function leaves the compiler
> entirely unimpressed.  Your patch only scratched the surface of the
> problem; so I went for below patch.  Further cleanup should be done but
> that would be unsuitable for 2.6.19 now that -rc4 is out.

It's better.

Thanks,

Yoichi

<Prev in Thread] Current Thread [Next in Thread>