linux-mips
[Top] [All Lists]

Re: [PATCH] fix clocksource parameter for low frequency timer.

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] fix clocksource parameter for low frequency timer.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 27 Oct 2006 16:57:58 +0100
Cc: linux-mips@linux-mips.org, m_lachwani@yahoo.com, creideiki+linux-mips@ferretporn.se
In-reply-to: <20061026.230937.41197595.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20061026.230937.41197595.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.2i
On Thu, Oct 26, 2006 at 11:09:37PM +0900, Atsushi Nemoto wrote:

> The current shift value in clocksource was not suitable for low
> frequency timer.  Find the shift value in runtime to avoid undesirable
> overflow.  Also calculate a somewhat reasonable rating value based on
> its frequency.

Looks fine to me and even Thomas Gleixner loves the idea of having code
to find the factor automatically, so it may become generic code after
2.6.19.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>