| To: | m_lachwani@yahoo.com |
|---|---|
| Subject: | Re: [PATCH] rest of works for migration to GENERIC_TIME |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Mon, 23 Oct 2006 11:09:00 +0900 (JST) |
| Cc: | linux-mips@linux-mips.org, ralf@linux-mips.org |
| In-reply-to: | <20061022193958.4188.qmail@web37509.mail.mud.yahoo.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20061023.033407.104640794.anemo@mba.ocn.ne.jp> <20061022193958.4188.qmail@web37509.mail.mud.yahoo.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sun, 22 Oct 2006 12:39:58 -0700 (PDT), Manish Lachwani <m_lachwani@yahoo.com> wrote: > The init_mips_clocksource() call is made via > module_init(). It does not need to be explicitly > called in time_init() after plat_timer_setup(). Yes, module_init() can do this, but I have no good reason to use module_init() here. Actually x86's hpet.c, i8253.c and tsc.c are using module_init(), these usages would avoid modifying i386/kernel/time.c every time new clocksource added. For MIPS, init_mips_clocksource is generic and live in mips/kernel/time.c, so I feel calling it directly is good and enough. --- Atsushi Nemoto |
| Previous by Date: | Re: [PATCH] rest of works for migration to GENERIC_TIME, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH] rest of works for migration to GENERIC_TIME, Atsushi Nemoto |
| Previous by Thread: | Re: [PATCH] rest of works for migration to GENERIC_TIME, Manish Lachwani |
| Next by Thread: | Re: [PATCH] rest of works for migration to GENERIC_TIME, Atsushi Nemoto |
| Indexes: | [Date] [Thread] [Top] [All Lists] |