linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS] merge a few printk in check_wait()

To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Subject: Re: [PATCH][MIPS] merge a few printk in check_wait()
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Wed, 18 Oct 2006 18:00:02 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips <linux-mips@linux-mips.org>
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=rtJfwt7HCku2UqZAl5eR02xD6efTWTU5n6YhW2/Z7zmb56YPE0VC6HeH6hQZ+TYTAN8d13aoazdvIFcytne7eFSGfNZGmVzz2zfuwbraYukGFREdritS/NlINR3E22u/llhEyYOQ7oayYPfR20AkRUImnt8Ul/p8sk7UVMLqRK0=
In-reply-to: <20061019002718.1ca0ec56.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20061019002718.1ca0ec56.yoichi_yuasa@tripeaks.co.jp>
Reply-to: Franck <vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Hi,

Yoichi Yuasa wrote:
> Hi Ralf,
> 
> This patch has merged a few printk in check_wait().
> 
> Yoichi
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> 
> diff -pruN -X mips/Documentation/dontdiff 
> mips-orig/arch/mips/kernel/cpu-probe.c mips/arch/mips/kernel/cpu-probe.c
> --- mips-orig/arch/mips/kernel/cpu-probe.c    2006-10-18 10:20:24.397574000 
> +0900
> +++ mips/arch/mips/kernel/cpu-probe.c 2006-10-18 10:28:53.113366750 +0900
> @@ -120,11 +120,9 @@ static inline void check_wait(void)

does it really need to be inlined ?

>       case CPU_R3081:
[snip]
> +
> +     if (cpu_wait)
> +             printk(" available.\n");
> +     else
> +             printk(" unavailable.\n");

what about:

        printk(" %savailable.\n", cpu_wait ? "" : "un");


                Franck

<Prev in Thread] Current Thread [Next in Thread>