linux-mips
[Top] [All Lists]

Re: PATCH] cleanup hardcoding __pa/__va macros etc. (take-5)

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: PATCH] cleanup hardcoding __pa/__va macros etc. (take-5)
From: girish <girishvg@gmail.com>
Date: Sat, 30 Sep 2006 03:33:01 +0900
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=Lm7Fo35+NL1D3NqUcT5c/98kBMQvJ3+BdvXdzd1zali9nqaqhng3uLX/ApwRZ0QyuKomYdo/PfYdJOqHJA+1hN/YMXDyca3/95B+6E0FivcNnpEtMViiWkhSpOj1vqGFweYECvoNsY6aqp8eUK+9kAXnEuKa1UheK9HaWWu33f8=
In-reply-to: <20060930.025956.108739154.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <C140DCAC.7A1C%girishvg@gmail.com> <20060928232956.GE3394@linux-mips.org> <B3C723F6-A2B3-4A0E-88BB-FF36AB58FFB4@gmail.com> <20060930.025956.108739154.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org

On Sep 30, 2006, at 2:59 AM, Atsushi Nemoto wrote:

On Fri, 29 Sep 2006 23:45:12 +0900, girish <girishvg@gmail.com> wrote:
Please find attached patch created from 2.6.18 (kernel.org) tree.
Let me
know if this is alright.

Signed-off-by: Girish V. Gulawani <girishvg@gmail.com>

-#ifdef CONFIG_ISA
-       if (low < max_dma)
+       if (low < max_dma) }

This doesn't quite compile.


Stupid mistake. Fixed & resending.

Looks good to me, except for page.h part.

I agree, but as of now, I do not have any better solution. If & when I will implement kernel page table for memory above 2000_0000, I plan to give it a through mapping. That is to say, 4000_0000 physical mapped to 4000_0000 virtual. In that case the page.h __pa/__va macros stand a chance (^_^;)

If somebody has already done kernel page table implementation, could you please pass on the relevant patch? Thanks.


<Prev in Thread] Current Thread [Next in Thread>