linux-mips
[Top] [All Lists]

Re: [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2)

To: girishvg@gmail.com
Subject: Re: [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2)
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Wed, 27 Sep 2006 01:35:53 +0900 (JST)
Cc: linux-mips@linux-mips.org
In-reply-to: <C13F744E.72CB%girishvg@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060926.180240.109570923.nemoto@toshiba-tops.co.jp> <C13F744E.72CB%girishvg@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 27 Sep 2006 00:20:30 +0900, girish <girishvg@gmail.com> wrote:
> But, then again treating all addresses as above PAGE_OFFSET is also wrong :)

It would be a design not a bug :-)

> I looked at it just as a work around. These macros are called from so many
> other places that if an access is made at say 4000_0000 the kernel will oops
> telling it was C000_0000 access error. Now that confused me a lot! With this
> change now kernel oops on 4000_0000 :)

Yes, 4000_0000, which is wrong too.  And it _hides_ wrong usage of
vaddr/paddr.  Bad side effect :)

> Anyway, you may ignore __pa/__va macros.
> 
> Could you please look into other changes I proposed?

__pa() returns "unsigned long" and __va() returns "void *" so some
casts are also redundant.  

Other parts looks good for me.
---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>