linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] [MIPS] lockdep: add STACKTRACE_SUPPORT and enable LOCKDE

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 2/3] [MIPS] lockdep: add STACKTRACE_SUPPORT and enable LOCKDEP_SUPPORT
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Tue, 26 Sep 2006 17:58:12 +0200
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, mingo@redhat.com
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=rWWcak18juvALB3umGsq28Klr6iE5mvPBIPaqz4jCkBqP7tfeq/FEx/f+afZUMu+XglYbWTMFf9EsNiOjK0BmXGFcFXEyY0XgDwD/iMMECbDYzdBgERxLVyOohcyY5IK4++gH2cg2knPc51OeAW2btV9093zN09UGvoDc7XFFNw=
In-reply-to: <20060926.234401.08077257.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060926.234401.08077257.anemo@mba.ocn.ne.jp>
Reply-to: Franck <vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Hi Atsushi

Atsushi Nemoto wrote:
> Implement stacktrace interface by using unwind_stack().
> And enable lockdep support.
> 
[snip]
> + */
> +static inline void
> +save_raw_context_stack(struct stack_trace *trace, unsigned int skip,
> +                    unsigned long reg29)
> +{
[snip]
> +
> +static inline struct pt_regs *
> +save_context_stack(struct stack_trace *trace, unsigned int skip,
> +                struct task_struct *task, struct pt_regs *regs)
> +{
> +     unsigned long sp = regs->regs[29];

Any reasons why marking these 2 functions as inlined ? IMHO gcc is now
good enough for this decision.

                Franck

<Prev in Thread] Current Thread [Next in Thread>