linux-mips
[Top] [All Lists]

Re: [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2)

To: girishvg@gmail.com
Subject: Re: [PATCH] cleanup hardcoding __pa/__va macros etc. (take-2)
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Tue, 26 Sep 2006 00:43:18 +0900 (JST)
Cc: linux-mips@linux-mips.org
In-reply-to: <C13E1C13.6FDC%girishvg@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060925.002616.126574366.anemo@mba.ocn.ne.jp> <C13E1C13.6FDC%girishvg@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 25 Sep 2006 23:51:46 +0900, girish <girishvg@gmail.com> wrote:
> Here is the patch again, attached as a text file. I don't have idea how
> these macros should be on a 64bit machine, so I just left them as it is.
> Could you please verify these macros again?

Well, I should ask first: Why do you change __pa() and __va() ?

I can not see point of ISMAPPED() testing.  And these macros are used
quite often so they should be as fast as possible.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>