linux-mips
[Top] [All Lists]

Re: [PATCH] fstatat syscall names

To: linux-mips@linux-mips.org, richard@codesourcery.com
Subject: Re: [PATCH] fstatat syscall names
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 19 Sep 2006 23:44:41 +0100
In-reply-to: <877j02xozk.fsf@talisman.home>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <877j02xozk.fsf@talisman.home>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Sun, Sep 17, 2006 at 08:38:39PM +0100, Richard Sandiford wrote:

> MIPS is the only port to call its fstatat()-related syscalls
> "__NR_fstatat".  Now I can see why that might be seen as every
> other port being wrong, but I think for o32, it is at best confusing.
> __NR_fstat provides a plain (32-bit) stat while __NR_fstatat provides a
> 64-bit stat.  Changing the name to __NR_fstatat64 would make things more
> explicit, match x86, and make the glibc port slightly easier.
> 
> The current name is more appropriate for n32 and n64, but it would be
> appropriate for other 64-bit targets too, and those targets have chosen
> to call it __NR_newfstatat instead.  Using the same name for MIPS would
> again be more consistent and make the glibc port slightly easier.
> 
> I'm not wedded to this idea if the current names are preferred,
> but FWIW...

I may have prefered the current naming at the time because they seemed to
be more logical to me when I choose those names but I'm not married to
them either.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>