linux-mips
[Top] [All Lists]

Re: [PATCH] au1x00 serial real interrupt

To: Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH] au1x00 serial real interrupt
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Tue, 19 Sep 2006 00:13:03 +0400
Cc: linux-mips@linux-mips.org
In-reply-to: <4502ED14.6080506@ru.mvista.com>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060522165244.GA16223@enneenne.com> <44FD9587.3030708@ru.mvista.com> <4502ED14.6080506@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Sergei Shtylyov wrote:

diff --git a/include/asm-mips/serial.h b/include/asm-mips/serial.h
index 7b23664..0197062 100644
--- a/include/asm-mips/serial.h
+++ b/include/asm-mips/serial.h
@@ -11,6 +11,14 @@
#include <linux/config.h> +#ifdef CONFIG_SOC_AU1X00
+/*
+ * We have to redefine "is_real_interrupt()" for Au1x00 CPUs...
+ */
+#undef is_real_interrupt
+#define is_real_interrupt(irq)    ((irq) != ~0)
+#endif
+
 /*
  * This assumes you have a 1.8432 MHz clock for your UART.
  *

Well, after looking at drivers/serial/8250.c a bit more, I think this may be even more simlified since that driver seems to treat the negative values as completely invalid anyway. IOW, we can just:

#define is_real_interrupt(irq)    1

Rodolfo, can you do this (possibly adding more elaborate comment about UART0 using IRQ0)?

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>