linux-mips
[Top] [All Lists]

Re: [PATCH] au1x00 serial real interrupt

To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] au1x00 serial real interrupt
From: Russell King <rmk@arm.linux.org.uk>
Date: Sat, 9 Sep 2006 17:39:07 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, Rodolfo Giometti <giometti@linux.it>, linux-mips@linux-mips.org
In-reply-to: <4502ED14.6080506@ru.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060522165244.GA16223@enneenne.com> <44FD9587.3030708@ru.mvista.com> <4502ED14.6080506@ru.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Sat, Sep 09, 2006 at 08:34:28PM +0400, Sergei Shtylyov wrote:
>    Well, after looking at drivers/serial/8250.c a bit more, I think this 
>    may be even more simlified since that driver seems to treat the negative 
> values as completely invalid anyway. IOW, we can just:
> 
> #define is_real_interrupt(irq)        1
> 
>    Russel, what do you think?

That's Russell 8)

Well, if you need IRQ0 to be real then redefining is_real_interrupt()
is the correct way forward.

However, Linus' policy is that IRQ0 shall be invalid at least on PCI
systems, and architectures _should_ remap their real IRQ0 to some other
number.  Personally I don't like this.  Hence why I prefer to give people
the option.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

<Prev in Thread] Current Thread [Next in Thread>