linux-mips
[Top] [All Lists]

Re: [MIPS] Fix COW D-cache aliasing on fork

To: linux-mips@linux-mips.org
Subject: Re: [MIPS] Fix COW D-cache aliasing on fork
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Fri, 01 Sep 2006 12:35:16 +0900 (JST)
Cc: ralf@linux-mips.org, nigel@mips.com
In-reply-to: <S20037621AbWHaUco/20060831203244Z+5697@ftp.linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <S20037621AbWHaUco/20060831203244Z+5697@ftp.linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 31 Aug 2006 21:32:39 +0100, linux-mips@linux-mips.org wrote:
> Author: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Thu Aug 24 00:31:30 2006 +0900
> Comitter: Ralf Baechle <ralf@linux-mips.org> Thu Aug 31 19:50:02 2006 +0100
> Commit: b895b66990f22a8a030c41390c538660a02bb97f
> Gitweb: http://www.linux-mips.org/g/linux/b895b669
> Branch: master

Thanks!!!

And please commit this fix too.


The tlbidx variable should be signed int so that "tlbidx < 0"
comparison works correctly.  Nigel Stephens <nigel@mips.com> pointed
this out.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c
index 2cfdc0b..bbc9458 100644
--- a/arch/mips/mm/init.c
+++ b/arch/mips/mm/init.c
@@ -136,7 +136,7 @@ static inline void *kmap_coherent(struct
        unsigned long vaddr, flags, entrylo;
        unsigned long old_ctx;
        pte_t pte;
-       unsigned int tlbidx;
+       int tlbidx;
 
        inc_preempt_count();
        idx = (addr >> PAGE_SHIFT) & (FIX_N_COLOURS - 1);

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [MIPS] Fix COW D-cache aliasing on fork, Atsushi Nemoto <=