linux-mips
[Top] [All Lists]

Re: [PATCH] RM9000 serial driver

To: Thomas Koeller <thomas.koeller@baslerweb.com>
Subject: Re: [PATCH] RM9000 serial driver
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Wed, 30 Aug 2006 15:59:57 +0400
Cc: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>, rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org, Thomas Köller <thomas@koeller.dyndns.org>
In-reply-to: <200608300105.26921.thomas.koeller@baslerweb.com>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200608102318.52143.thomas.koeller@baslerweb.com> <200608222227.20181.thomas.koeller@baslerweb.com> <44F459DD.8060902@ru.mvista.com> <200608300105.26921.thomas.koeller@baslerweb.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

Thomas Koeller wrote:

Also, it seems to me that the whole register-mapping stuff conflicts with
autodetection, because autoconfig() uses serial_inp() and serial_outp()
before the port types, and hence the mapping requirements, are known.

   Port types have nothing to do with this. Or at least they hadn't until
your recent patch. :-)
   iotype was used to identify the addressing scheme, and it's alsready
known beforehand.

How so? If I do not yet know which hardware I am dealing with, how can I know
the iotype?

The iotype is passed to driver when registering the platform device or calling early_serial_setup(). There's absolutely no way for 8250.c to figure it out yourself. Please, review the driver's code more carefully. It was not at all that complex task to copy from the existing Alchemy code...

Thomas

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>