linux-mips
[Top] [All Lists]

Re: [PATCH] fixup for pci config_access on alchemy au1x000

To: Alexander Bigga <ab@mycable.de>
Subject: Re: [PATCH] fixup for pci config_access on alchemy au1x000
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 29 Aug 2006 16:56:07 +0100
Cc: linux-mips@linux-mips.org, ppopov@embeddedalley.com
In-reply-to: <200608291648.35250.ab@mycable.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200608291648.35250.ab@mycable.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Tue, Aug 29, 2006 at 04:48:34PM +0200, Alexander Bigga wrote:

> What do you think about my fixup-patch? 
> Nobody's using the get_vm_area()-call without any flag ("0"). Was it only 
> forgotten in the  arch/mips/pci/ops-au1000.c?
> 
> Or am I completely wrong?
> 
> Thanks a lot for your comments!

The patch looks ok, so just the usual technicalities:

 - Please include a Signed-off-by: line.
 - Don't use a bloody crapmailer that garbles patches into some sort of
   ASCII spinach.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>