linux-mips
[Top] [All Lists]

Re: [PATCH] NEC EMMA2RH support, revisited

To: dpervushin@ru.mvista.com
Subject: Re: [PATCH] NEC EMMA2RH support, revisited
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Thu, 24 Aug 2006 22:36:56 +0400
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <1148208787.6884.9.camel@diimka-laptop>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1148208787.6884.9.camel@diimka-laptop>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803
Hello.

dmitry pervushin wrote:

The patch below is to support NEC EMMA2RH Mark-eins board (R5500-based)
Thanks for helping and valuable comments:
        the whole linux-mips comminuty
        Ralf Baechle
        Martin Michlmayr
        Thiemo Seufer

   It seems that the community have overlooked at least one issue with this 
code:

Index: linux/arch/mips/emma2rh/markeins/setup.c
===================================================================
--- /dev/null
+++ linux/arch/mips/emma2rh/markeins/setup.c
[...]
+static void inline __init markeins_sio_setup(void)
+{
+#ifdef CONFIG_KGDB_8250

I wonder what it's doing in the Linux/MIPS patch while it's only relevant to the cross-arch KGDB patchset.

+       struct uart_port emma_port;
+
+       memset(&emma_port, 0, sizeof(emma_port));
+
+       emma_port.flags =
+           UPF_BOOT_AUTOCONF | UPF_SKIP_TEST;
+       emma_port.iotype = UPIO_MEM;
+       emma_port.regshift = 4; /* I/O addresses are every 8 bytes */
+       emma_port.uartclk = 18544000;   /* Clock rate of the chip */
+
+       emma_port.line = 0;
+       emma_port.mapbase = KSEG1ADDR(EMMA2RH_PFUR0_BASE + 3);
+       emma_port.membase = (u8*)emma_port.mapbase;
+       early_serial_setup(&emma_port);
+
+       emma_port.line = 1;
+       emma_port.mapbase = KSEG1ADDR(EMMA2RH_PFUR1_BASE + 3);
+       emma_port.membase = (u8*)emma_port.mapbase;
+       early_serial_setup(&emma_port);
+
+       emma_port.irq = EMMA2RH_IRQ_PFUR1;
+       kgdb8250_add_port(1, &emma_port);
+#endif

Why you #ifdef out early_serial_setup() calls is even more interesting. How this kernel is supposed to work at all with such code?!

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>