linux-mips
[Top] [All Lists]

Re: [PATCH] fix cache coherency issues

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] fix cache coherency issues
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 24 Aug 2006 12:15:15 +0100
Cc: nigel@mips.com, linux-mips@linux-mips.org
In-reply-to: <20060824.101531.07643963.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060523.003424.104640954.anemo@mba.ocn.ne.jp> <20060824.003130.25910593.anemo@mba.ocn.ne.jp> <44EC87C9.8010402@mips.com> <20060824.101531.07643963.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Thu, Aug 24, 2006 at 10:15:31AM +0900, Atsushi Nemoto wrote:

> On Wed, 23 Aug 2006 17:52:25 +0100, Nigel Stephens <nigel@mips.com> wrote:
> > Doesn't tlbidx need to be declared as a signed int, else the compiler
> > could optimize away this comparison.
> 
> You are right.  I'll fix it.  Thanks.

Your patch also still contains copy_user_page().  The only user of it used
to be copy_user_highpage() so after our rewrite it can go away.  I've
already applied both fixes to my working version of the patch.

Your patch only maps the source page.  I'm trying to map the destination
page also and I'm hitting a few issues with it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>