| To: | vagabon.xyz@gmail.com |
|---|---|
| Subject: | Re: [PATCH] Remove mfinfo[64] used by get_wchan() |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Fri, 18 Aug 2006 17:15:58 +0900 (JST) |
| Cc: | ralf@linux-mips.org, linux-mips@linux-mips.org |
| In-reply-to: | <44E57161.5060104@innova-card.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <44E475C8.5000105@innova-card.com> <20060818.115213.108739385.nemoto@toshiba-tops.co.jp> <44E57161.5060104@innova-card.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Fri, 18 Aug 2006 09:50:57 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote: > >> + unsigned long size = 0; > > > > You must pass some non-zero size even if CONFIG_KALLSYMS was not set. > > Otherwise schedule_mfi will not be initialized as expected. Actually, > > this is not a problem of this patch, but we missed this point on > > previous cleanups for the get_frame_info()... > > or maybe we can just fix get_frame_info() and make it more robust ? Maybe. But info->func_size == 0 is valid input when it was called via show_backtrace. If an exception occured on a first instruction of a function, get_frame_info() should return 1. So it would be easy to give some appropriate (128?) size here. --- Atsushi Nemoto |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Remove mfinfo[64] used by get_wchan(), Franck Bui-Huu |
|---|---|
| Next by Date: | Re: [PATCH] Image capturing driver for Basler eXcite smart camera, Pavel Machek |
| Previous by Thread: | Re: [PATCH] Remove mfinfo[64] used by get_wchan(), Franck Bui-Huu |
| Next by Thread: | Re: [PATCH] Remove mfinfo[64] used by get_wchan(), Franck Bui-Huu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |