linux-mips
[Top] [All Lists]

RE: [MIPS] SB1: Build fix: delete initialization of flush_icache_page po

To: linux-mips@linux-mips.org
Subject: RE: [MIPS] SB1: Build fix: delete initialization of flush_icache_page pointer.
From: "Mark E Mason" <mark.e.mason@broadcom.com>
Date: Thu, 17 Aug 2006 14:20:07 -0700
In-reply-to: <S20037884AbWHMBM7/20060813011259Z+2871@ftp.linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Thread-index: Aca+daILnSOlGluWQ7Srz0r4G3TUegDzPiqg
Thread-topic: [MIPS] SB1: Build fix: delete initialization of flush_icache_page pointer.
Hello all,

FYI:

The sb1_flash_icache_page change below breaks causes 1480 kernels to
hang after freeing memory:

[4294675.358000] Looking up port of RPC 100003/2 on 192.168.0.151

[4294675.360000] Looking up port of RPC 100005/1 on 192.168.0.151

[4294675.578000] VFS: Mounted root (nfs filesystem) readonly.

[4294675.579000] Freeing unused kernel memory: 212k freed           

The console still echos return characters, but booting doesn't progress
beyond this point.

Right before this change, everything appears to be ok.

/Mark

> -----Original Message-----
> From: linux-git-patches-bounce@linux-mips.org 
> [mailto:linux-git-patches-bounce@linux-mips.org] On Behalf Of 
> linux-mips@linux-mips.org
> Sent: Saturday, August 12, 2006 6:13 PM
> To: git-commits@linux-mips.org
> Subject: [MIPS] SB1: Build fix: delete initialization of 
> flush_icache_page pointer.
> 
> Author: Ralf Baechle <ralf@linux-mips.org> Sun Aug 13 
> 02:00:02 2006 +0100
> Commit: d95bc28e8c0bc1c39ef300ec2bca6ce99245cb50
> Gitweb: http://www.linux-mips.org/g/linux/d95bc28e
> Branch: master
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
> ---
> 
>  arch/mips/mm/c-sb1.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/mm/c-sb1.c b/arch/mips/mm/c-sb1.c
> index 5df454e..4bd9ad8 100644
> --- a/arch/mips/mm/c-sb1.c
> +++ b/arch/mips/mm/c-sb1.c
> @@ -520,7 +520,6 @@ #endif
>  
>       /* These routines are for Icache coherence with the Dcache */
>       flush_icache_range = sb1_flush_icache_range;
> -     flush_icache_page = sb1_flush_icache_page;
>       __flush_icache_page = sb1_flush_icache_page;
>       flush_icache_all = __sb1_flush_icache_all; /* local only */
>  
> 
> 
> 


<Prev in Thread] Current Thread [Next in Thread>