| To: | Thomas Koeller <thomas@koeller.dyndns.org> |
|---|---|
| Subject: | Re: [PATCH] Added MIPS RM9K watchdog driver |
| From: | Wim Van Sebroeck <wim@iguana.be> |
| Date: | Mon, 14 Aug 2006 17:50:45 +0200 |
| Cc: | Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| In-reply-to: | <200608120149.23380.thomas@koeller.dyndns.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200608102319.13679.thomas@koeller.dyndns.org> <20060811205639.GK26930@redhat.com> <200608120149.23380.thomas@koeller.dyndns.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.2.1i |
Hi All, > > > +#include <linux/config.h> > > > > not needed. > > It is, otherwise I do not get CONFIG_WATCHDOG_NOWAYOUT. We'll fix this in the watchdog.h include file. > > > +static int nowayout = > > > +#if defined(CONFIG_WATCHDOG_NOWAYOUT) > > > + 1; > > > +#else > > > + 0; > > > +#endif > > > > static int nowayout = CONFIG_WATCHDOG_NOWAYOUT; > > > > should work. > > Does not work. If the option is not selected, CONFIG_WATCHDOG_NOWAYOUT > is undefined, not zero. This should be: static int nowayout = WATCHDOG_NOWAYOUT; Can you resent me your latest diff? Thanks, Wim. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Added MIPS RM9K watchdog driver, Luca |
|---|---|
| Next by Date: | Re: [PATCH] Image capturing driver for Basler eXcite smart camera, Thomas Koeller |
| Previous by Thread: | Re: [PATCH] Added MIPS RM9K watchdog driver, Dave Jones |
| Next by Thread: | Re: [PATCH] MIPS RM9K watchdog driver, Thomas Koeller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |