| To: | Alan Cox <alan@lxorguk.ukuu.org.uk> |
|---|---|
| Subject: | Re: [PATCH] Added MIPS RM9K watchdog driver |
| From: | Thomas Koeller <thomas@koeller.dyndns.org> |
| Date: | Sat, 12 Aug 2006 18:06:02 +0200 |
| Cc: | wim@iguana.be, linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| In-reply-to: | <1155326835.24077.116.camel@localhost.localdomain> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200608102319.13679.thomas@koeller.dyndns.org> <1155326835.24077.116.camel@localhost.localdomain> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | KMail/1.9.3 |
On Friday 11 August 2006 22:07, Alan Cox wrote: > > + printk(KERN_WARNING "%s: watchdog expired - resetting system\n", > > + wdt_gpi_name); > > + > > + *(volatile char *) flagaddr |= 0x01; > > + *(volatile char *) resetaddr = powercycle ? 0x01 : 0x2; > > + iob(); > > + while (1) continue; > > cpu_relax(); I tried to find out about the purpose of cpu_relax(). On MIPS, at least, it maps to barrier(). I do not quite understand why I would need a barrier() in this place. Would you, or someone else, care to enlighten me? I am sending a revised patch in a separate mail. Thomas -- Thomas Koeller thomas@koeller.dyndns.org |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Au1200 OHCI/EHCI fixes, Yoichi Yuasa |
|---|---|
| Next by Date: | [PATCH] MIPS RM9K watchdog driver, thomas |
| Previous by Thread: | Re: [PATCH] Added MIPS RM9K watchdog driver, Alan Cox |
| Next by Thread: | Re: [PATCH] Added MIPS RM9K watchdog driver, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |