linux-mips
[Top] [All Lists]

Re: [PATCH 2/6] setup.c: move initrd code inside dedicated functions

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 2/6] setup.c: move initrd code inside dedicated functions
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Fri, 11 Aug 2006 17:13:01 +0200
Cc: vagabon.xyz@gmail.com, linux-mips@linux-mips.org, ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=fRq+eSRu7yeslti7/doz5ZnxONKkhCInsWCboKyPwxCE1KE1UtJ9lqMUqhGT7c5u9LYEf8JQSPnqhGUq0kmGfr/y6A8ZdQU+kImlU8UXvSkphcIRrmCJLt3yrt9RfPiVtoD+ZBckhOfM7QE4IH2zsWLC0xvxvsb76vLGFx3+lf0=
In-reply-to: <20060811.235056.126141886.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11551351581277-git-send-email-vagabon.xyz@gmail.com> <1155135159394-git-send-email-vagabon.xyz@gmail.com> <20060811.235056.126141886.anemo@mba.ocn.ne.jp>
Reply-to: Franck <vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Atsushi Nemoto wrote:
> On Wed,  9 Aug 2006 16:52:34 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
> wrote:
>> +    unsigned long initrd_size = 
>> +            (unsigned long)initrd_end - (unsigned long)initrd_start;
> 
> While initrd_end and initrd_start are unsigned long, these casts are
> redundant.
> 

Absolutely. I don't remember why I added these useless casts...

>> +    printk(KERN_INFO "Initial ramdisk at: 0x%p (%lu bytes)\n",
>> +           (void *)initrd_start, initrd_size);
> 
> You can use "0x%lx" for initrd_start and remove the cast.  I know this
> fragment are copied from corrent code as is, but it would be a good
> chance to clean it up.
> 

You're right.

I'll change that and make a take #3.

Thanks for your comments.

                Franck

<Prev in Thread] Current Thread [Next in Thread>