linux-mips
[Top] [All Lists]

Re: [PATCH 2/6] setup.c: move initrd code inside dedicated functions

To: vagabon.xyz@gmail.com
Subject: Re: [PATCH 2/6] setup.c: move initrd code inside dedicated functions
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Fri, 11 Aug 2006 23:50:56 +0900 (JST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp
In-reply-to: <1155135159394-git-send-email-vagabon.xyz@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <11551351581277-git-send-email-vagabon.xyz@gmail.com> <1155135159394-git-send-email-vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed,  9 Aug 2006 16:52:34 +0200, Franck Bui-Huu <vagabon.xyz@gmail.com> 
wrote:
> +     unsigned long initrd_size = 
> +             (unsigned long)initrd_end - (unsigned long)initrd_start;

While initrd_end and initrd_start are unsigned long, these casts are
redundant.

> +     printk(KERN_INFO "Initial ramdisk at: 0x%p (%lu bytes)\n",
> +            (void *)initrd_start, initrd_size);

You can use "0x%lx" for initrd_start and remove the cast.  I know this
fragment are copied from corrent code as is, but it would be a good
chance to clean it up.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>