linux-mips
[Top] [All Lists]

Re: [PATCH] 2/7 AU1100 MMC support

To: Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH] 2/7 AU1100 MMC support
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Thu, 10 Aug 2006 16:29:03 +0200
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-mips@linux-mips.org
In-reply-to: <20060810133658.GZ342@enneenne.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20060809210843.GC13145@enneenne.com> <44DB34C2.3090302@ru.mvista.com> <20060810133658.GZ342@enneenne.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.11
Hi Rodolfo,

On Thu, Aug 10, 2006 at 03:36:58PM +0200, Rodolfo Giometti wrote:
> Again as above. For my specific board I use:
> 
>    #if defined(CONFIG_MIPS_DB1200)
>        data = bcsr->sig_status & val;
>    #elif defined(CONFIG_MIPS_MYBOARD)
>        specific code...
>    #endif
> 
> Maybe we should modify my solution including other DB1x00 boards
> ifdef. However, the important thing is to protect againt variable
> "bcsr" if a specific board doesn't support it.

FWIW, I think the whole Db/Pb board specific mess should be removed
from the driver entirely and placed in the respective boards' code.
The board should then pass on a struct to the driver with hooks
into those functions (like in arch/arm/mach-pxa/corgi.c).

It is on my list of things to fix for a later time. If noone beats me
to it, I'm going to do it, but it may take a while since I'm working
on other things.

Thanks,

-- 
 ml.

<Prev in Thread] Current Thread [Next in Thread>