linux-mips
[Top] [All Lists]

Re: [PATCH 6/6] setup.c: use early_param() for early command line parsin

To: Thiemo Seufer <ths@networkno.de>
Subject: Re: [PATCH 6/6] setup.c: use early_param() for early command line parsing
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
Date: Tue, 08 Aug 2006 16:00:30 +0200
Cc: Franck Bui-Huu <vagabon.xyz@gmail.com>, linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp, ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:from; b=T1/3yy+3EDf+J74XIizhrtqKq6HvNGwVhorvdPQH/NUt4b3GDi1YAfORmIjMqTf+CvQ0cAX/CGUmEYOwFKira0HhK2QvPoeUxaZzG9dyisFpdqfOFmDrF6Q945w9KLydEGNy7OXPHGWPbbb92cvf5/C6Lf0vMuWVMqpgO55aoJw=
In-reply-to: <20060808125604.GI29989@networkno.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1155041312273-git-send-email-vagabon.xyz@gmail.com> <1155041313139-git-send-email-vagabon.xyz@gmail.com> <20060808125604.GI29989@networkno.de>
Reply-to: Franck <vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Thiemo Seufer wrote:
> Franck Bui-Huu wrote:
>> There's no point to rewrite some logic to parse command line
>> to pass initrd parameters or to declare a user memory area.
>> We could use instead parse_early_param() that does the same
>> thing.
>>
>> NOTE ! This patch also changes the initrd semantic. Old code
>> was expecting "rd_start=xxx rd_size=xxx" which uses two
>> parameters. Now the code expects "initrd=xxx@yyy" which is
>> really simpler to parse and to use. No default config files
>> use these parameters anyways but not sure for bootloader's
>> users...
> 
> This code is there precisely because most mips bootloaders use
> rd_start/rd_size.

OK, I guess we have to stick with this weird semantic...

> It also is IMHO a bad idea to overload the
> semantics of initrd= with both file names and memory locations.
> 

I wasn't aware of any file name usages. Can you give a pointer ?

Thanks

                Franck

<Prev in Thread] Current Thread [Next in Thread>