linux-mips
[Top] [All Lists]

Re: [PATCH 6/6] setup.c: use early_param() for early command line parsin

To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Subject: Re: [PATCH 6/6] setup.c: use early_param() for early command line parsing
From: Thiemo Seufer <ths@networkno.de>
Date: Tue, 8 Aug 2006 13:56:04 +0100
Cc: linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp, ralf@linux-mips.org, yoichi_yuasa@tripeaks.co.jp
In-reply-to: <1155041313139-git-send-email-vagabon.xyz@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1155041312273-git-send-email-vagabon.xyz@gmail.com> <1155041313139-git-send-email-vagabon.xyz@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.12-2006-07-14
Franck Bui-Huu wrote:
> There's no point to rewrite some logic to parse command line
> to pass initrd parameters or to declare a user memory area.
> We could use instead parse_early_param() that does the same
> thing.
> 
> NOTE ! This patch also changes the initrd semantic. Old code
> was expecting "rd_start=xxx rd_size=xxx" which uses two
> parameters. Now the code expects "initrd=xxx@yyy" which is
> really simpler to parse and to use. No default config files
> use these parameters anyways but not sure for bootloader's
> users...

This code is there precisely because most mips bootloaders use
rd_start/rd_size. It also is IMHO a bad idea to overload the
semantics of initrd= with both file names and memory locations.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>