linux-mips
[Top] [All Lists]

Re: [PATCH] Cleanup bootmem_init()

To: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
Subject: Re: [PATCH] Cleanup bootmem_init()
From: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Date: Tue, 8 Aug 2006 06:47:01 +0900
Cc: yoichi_yuasa@tripeaks.co.jp, linux-mips@linux-mips.org, anemo@mba.ocn.ne.jp, ralf@linux-mips.org
In-reply-to: <cda58cb80608070835o37b83a5bwd4d931c9d2746a15@mail.gmail.com>
Organization: TriPeaks Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <44D34C84.9090902@innova-card.com> <20060807230346.2a578ba9.yoichi_yuasa@tripeaks.co.jp> <cda58cb80608070835o37b83a5bwd4d931c9d2746a15@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 7 Aug 2006 17:35:25 +0200
"Franck Bui-Huu" <vagabon.xyz@gmail.com> wrote:

> 2006/8/7, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>:
> > Hi
> >
> > On Fri, 04 Aug 2006 15:32:52 +0200
> > Franck Bui-Huu <vagabon.xyz@gmail.com> wrote:
> >
> > > This function although doing simple things is hard to follow. It's
> > > mainly due to:
> > >
> > >     - a lot of #ifdef
> > >     - bad local names
> > >     - redundant tests
> > >
> > > So this patch try to address these issues. It also do not use
> > > max_pfn global which is marked as an unused exported symbol.
> > >
> > > As a bonus side, it's now really easy to see what part of the
> > > code is for no-numa system.
> > >
> > > There's also no point to make this function inline.
> >
> > I seem to be able to bring together two #idef CONFIG_BLK_DEV_INITRD/#endif.
> >
> 
> Before doing that can you wait until tomorrow ?

Yes I can.

> I'm going to send a
> patchset that going futher in the cleanup than this single patch but I
> can't send it until tomorrow...

OK

Thanks,

Yoichi

<Prev in Thread] Current Thread [Next in Thread>